Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used Pasword Path instead of hard coding password #35

Merged
merged 5 commits into from
May 8, 2024
Merged

Used Pasword Path instead of hard coding password #35

merged 5 commits into from
May 8, 2024

Conversation

Phanco
Copy link
Member

@Phanco Phanco commented May 7, 2024 •
edited
Loading

What was the problem?

This PR resolves #34, Item 5

How was it solved?

  • DB_PASSWORD flag now became DB_PASSWORD_PATH
  • Developers need to create random password file before starting Docker psql

How was it tested?

  • DB and backend runs successfully locally and params verified on Docker Dashboard

@Phanco Phanco marked this pull request as ready for review May 7, 2024 15:30
@Phanco Phanco self-assigned this May 7, 2024
@Phanco Phanco requested a review from matjazv May 7, 2024 23:31
@Phanco Phanco requested a review from sameersubudhi May 8, 2024 11:54
sameersubudhi
sameersubudhi approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍
However, please consider the following recommendations.

packages/claim-backend/README.md Outdated Show resolved Hide resolved
packages/claim-backend/docker-compose.yml Outdated Show resolved Hide resolved
@Phanco Phanco enabled auto-merge (squash) May 8, 2024 14:17
@Phanco Phanco merged commit d914bd5 into development May 8, 2024
1 check passed
@Phanco Phanco deleted the 34-4-fix-hardcoded-credentials branch May 8, 2024 14:18
@shuse2 shuse2 mentioned this pull request May 14, 2024
Merged
@Phanco Phanco mentioned this pull request May 14, 2024
Merged
Phanco added a commit that referenced this pull request May 15, 2024
@Phanco @sameersubudhi
Used Pasword Path instead of hard coding password (#35)
5e1f2e7 
* Used Pasword Path instead of hard coding password

* Update yaml and README according to PR Review suggestion

---------

Co-authored-by: Sameer <[email protected]>
Phanco added a commit that referenced this pull request May 15, 2024
@Phanco @sameersubudhi
Used Pasword Path instead of hard coding password (#35)
38e1967 
* Used Pasword Path instead of hard coding password

* Update yaml and README according to PR Review suggestion

---------

Co-authored-by: Sameer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameersubudhi sameersubudhi sameersubudhi approved these changes

@matjazv matjazv matjazv approved these changes

Assignees

@Phanco Phanco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve Suggestions According to ToB Report 6, MAY 2024
3 participants
@Phanco @matjazv @sameersubudhi