style: adjust clang-format rules #2186
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See https://github.com/LizardByte/Sunshine/actions/runs/8072315274/job/22053784930 for all changes that will be applied when this PR is ready to merge. |
11 tasks
|
I made a proposal of changes in: |
ReenigneArcher
force-pushed
the
style-adjust-clang-format-rules
branch
from
bc96c71
to
534843f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2186 +/- ##
=======================================
Coverage 11.12% 11.13%
=======================================
Files 99 99
Lines 17211 17211
Branches 8023 8023
=======================================
+ Hits 1915 1916 +1
Misses 12594 12594
+ Partials 2702 2701 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ReenigneArcher
force-pushed
the
style-adjust-clang-format-rules
branch
from
9f7a6a8
to
938eeb6
Compare
ReenigneArcher
commented
Jun 27, 2024
|
Could we get this curly bracket on a new line? It looks very ugly in my opinion. Moving it still looks ugly, but less so... |
ReenigneArcher
force-pushed
the
style-adjust-clang-format-rules
branch
2 times, most recently
from
5f931d2
to
90f6aec
Compare
ReenigneArcher
added a commit
to LizardByte/Moonlight-XboxOG
that referenced
this pull request
Oct 19, 2024
ReenigneArcher
added a commit
to LizardByte/Moonlight-XboxOG
that referenced
this pull request
Oct 19, 2024
ReenigneArcher
force-pushed
the
style-adjust-clang-format-rules
branch
from
90f6aec
to
5297aec
Compare
Co-Authored-By: Vithorio Polten <[email protected]>
ReenigneArcher
force-pushed
the
style-adjust-clang-format-rules
branch
from
5297aec
to
796adce
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust clang-format rules, mostly to adjust break after return type behavior.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.