-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve flatpak start commands #3264
docs: improve flatpak start commands #3264
Conversation
@caveat-makes-software Do you think we should include anything else from the issues mentioned above? or #2839 ? Also does this also solve #2839? |
Hello again, yes, the fix for this issue also fixes #2839. I didn't find this issue earlier because it was already closed, but the two issues seem to be identical. The startup call for flatpak that I have provided should make the whole procedure independent of what the language is (I have a Portuguese/BR system as well), and I got it working this way. I think there is nothing else that needs to be included related to this. Regarding #2840: This issue boils down to the command |
@cjuniorfox any thoughts on this? Are you okay with your suggestion in the issue you made being implemented by this PR? |
33ccc35
to
2686259
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3264 +/- ##
=======================================
Coverage 11.12% 11.12%
=======================================
Files 99 99
Lines 17211 17211
Branches 8023 8023
=======================================
Hits 1915 1915
Misses 12594 12594
Partials 2702 2702
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Corrected documentation of startup calls for Linux+Flatpak: I have removed
$(pactl info | awk '/Server String/{print$3}')
and replaced it with$(id -u $whoami)
. This should allow Sunshine to find the Pulse audio server also on Linux installations that are not English.Issues Fixed or Closed
Type of Change
.github/...
)Checklist