Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve flatpak start commands #3264

Merged

Conversation

caveat-makes-software
Copy link
Contributor

@caveat-makes-software caveat-makes-software commented Oct 6, 2024

Description

Corrected documentation of startup calls for Linux+Flatpak: I have removed $(pactl info | awk '/Server String/{print$3}') and replaced it with $(id -u $whoami). This should allow Sunshine to find the Pulse audio server also on Linux installations that are not English.

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher changed the title Corrected documentation of startup calls for Linux+Flatpak: This reso… docs: improve flatpak start commands Oct 6, 2024
@ReenigneArcher
Copy link
Member

ReenigneArcher commented Oct 13, 2024

@caveat-makes-software Do you think we should include anything else from the issues mentioned above? or #2839 ?

Also does this also solve #2839?

@ReenigneArcher ReenigneArcher added this to the stable release milestone Oct 14, 2024
@caveat-makes-software
Copy link
Contributor Author

Hello again,

yes, the fix for this issue also fixes #2839. I didn't find this issue earlier because it was already closed, but the two issues seem to be identical. The startup call for flatpak that I have provided should make the whole procedure independent of what the language is (I have a Portuguese/BR system as well), and I got it working this way. I think there is nothing else that needs to be included related to this.

Regarding #2840: This issue boils down to the command
which sunshine
not finding anything. I dont know why this is, but I can confirm that it is not working from my side (Fedora 40). Thus: I think the suggestion provided by cjuniorfox should be implemented.

@ReenigneArcher
Copy link
Member

@cjuniorfox any thoughts on this? Are you okay with your suggestion in the issue you made being implemented by this PR?

Copy link

sonarcloud bot commented Oct 19, 2024

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.12%. Comparing base (d80fe79) to head (2686259).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3264   +/-   ##
=======================================
  Coverage   11.12%   11.12%           
=======================================
  Files          99       99           
  Lines       17211    17211           
  Branches     8023     8023           
=======================================
  Hits         1915     1915           
  Misses      12594    12594           
  Partials     2702     2702           
Flag Coverage Δ
Linux 8.42% <ø> (ø)
Windows 5.19% <ø> (ø)
macOS-13 13.60% <ø> (ø)
macOS-14 12.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) October 19, 2024 00:24
@ReenigneArcher ReenigneArcher merged commit fc78f5a into LizardByte:master Oct 19, 2024
36 checks passed
qiin2333 pushed a commit to qiin2333/Sunshine-Foundation that referenced this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants