Search by place. String provider. Detekt. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoSanMartin
changed the title
dellisd
requested changes
Jun 1, 2019
| suspend fun getSearchResults(query: String): List<SearchResult> = withContext(Dispatchers.IO) { | ||
| if (query.isEmpty()) return@withContext emptyList<SearchResult>() | ||
|
|
||
| val stops = getStops(query) |
There was a problem hiding this comment.
Suggested change
| val stops = getStops(query) | |
| getStops(query).takeIf { it.isNotEmpty() }?.let { /* Add header and append to search results */ } |
This could be made more idiomatic by using a takeIf followed by a let block where the header and results can be added to the output list.
| .executeCall() | ||
| .body() | ||
| ?.features() | ||
| ?.map { SearchResult.PlaceItem(it.placeName().orEmpty(), it.text().orEmpty()) } |
There was a problem hiding this comment.
Suggested change
| ?.map { SearchResult.PlaceItem(it.placeName().orEmpty(), it.text().orEmpty()) } | |
| ?.map { feature -> SearchResult.PlaceItem(feature.placeName().orEmpty(), feature.text().orEmpty()) } |
Add explicit lambda parameter name here
There was a problem hiding this comment.
Any particular reason for this? It's not overshadowed or anything. Are we avoiding the it implicit parameter altogether?
There was a problem hiding this comment.
I think it's more readable this way. it explicitly states what's being dealt with in the closure since it's a bit too confusing to infer at the bottom of a long chain of function calls.
dellisd
approved these changes
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes #28
Summary
Use
./gradlew detektto check for lint errorsTodo #43
Screenshots