Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: upper limit of errors and logs #3729

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Feature: upper limit of errors and logs #3729

wants to merge 17 commits into from

Conversation

1zumIQ
Copy link

@1zumIQ 1zumIQ commented May 5, 2024 •
edited
Loading

  1. 更改了默认error存储路径"./log/error/{config-name}/"
  2. 增加错误 存储上限
  3. 增加日志轮转上限
  4. 增加日志压缩
    2024-05-05_test.txt
image

@LmeSzinc
Copy link
Owner

LmeSzinc commented Jun 2, 2024

做大功能之前建议还是先讨论，不着急写代码

  1. Alas 后端默认每天 03:50 重启，所有 Alas 实例也会被重启，日志会打印到新日期的文件中，其实是不需要额外实现日志轮换的
  2. 添加的新功能需要对旧的兼容，也就是说改变了目录结构之后，旧目录下的过期 log 也应当被删除或者压缩
  3. 压缩算法不需要给选项，不会产生多少体验差距，选 zip 或者测试对 Alas 日志哪个压缩率最高选哪个

@LmeSzinc LmeSzinc added good first issue / 首次贡献 Good for newcomers feature request / 功能请求 New feature or requests labels Jun 2, 2024
@LmeSzinc LmeSzinc added the 需要修改 / Request changes Changes required in PR label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature request / 功能请求 New feature or requests good first issue / 首次贡献 Good for newcomers 需要修改 / Request changes Changes required in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1zumIQ @LmeSzinc