NEST-557: Add Markdown linting #47
Conversation
This comment has been minimized.
This comment has been minimized.
|
@Piedone Should I accept these words or? |
|
Don't add the internal Readme-only part to the Readme. Just fix here what's common. |
|
Ok, so I now get these errors. https://github.com/Lombiq/DotNest-Core-SDK/actions/runs/13381281403/job/37370164435 Should I wait for NEST-537 to be completed and then merge that or I can just manually fix them (basically copy what's done in 537 regarding versions in csproj files). |
|
Ideally, we'd wait for that issue to be completed indeed, yes. If you don't want to wait, we can merge this as-is, just make sure by running markdownlint locally that there are no linting violations. |
|
I ran markdownlint and only error is that line lengths should be 80 chars, but that error doesn't show in actual build (both locally or in GH action). It's not a rush, but maybe we can merge because this one is completed. But whatever you think it's the best in this case. |
|
We don't have that 80 chars limit configured, so I guess it's just that the local run didn't use the same config. So, it's OK. Let's wait for Bence then, please. |
NEST-557