-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-744: Add wrapper for the markdownlint-cli2 action #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
…ecause it's unnecessary due to how fast it completes
This reverts commit 07aa3f9.
…ync with Lombiq.NodeJs.Extensions
sarahelsaig
requested changes
May 26, 2024
Co-authored-by: Sára El-Saig <[email protected]>
…heck if it's really needed
BenedekFarkas
commented
Jun 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 5, 2024
sarahelsaig
approved these changes
Jun 5, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-744
Fixes #289
Note: The
markdown-lint
action andlombiq.markdownlint.json
contains comments to warn about synchronizing the version ofmarkdownlint
and configuration changes to Lombiq.NodeJs.Extensions (and vice versa). This is a slight inconvenience (having to maintain this in two places), but these are completely independent libraries providing different means to execute linting and the associated configuration changes are extremely rare/unlikely.