-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed nodeport issue on result-service.yml and vote-service.yml #10
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes involve modifications to the Kubernetes service specifications for two applications: Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hi @LondheShubham153 sir,
As we are using port-forwarding on kind k8s cluster to access the application on browser, we don't require Nodeport type in service files, so I have removed it from result-service.yml and vote-service.yml.
Summary by CodeRabbit
New Features
result
service now automatically assigns a node port, enhancing flexibility in port management.vote
service has been updated to a defaultClusterIP
type, optimizing internal communication.Bug Fixes
result
service, ensuring proper structure and readability.