feat: implement a What's New prompt #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we already have this |
IsaDavRod
requested changes
Mar 5, 2025
Samathingamajig
requested changes
Mar 6, 2025
Razboy20
previously requested changes
Mar 6, 2025
Samathingamajig
requested changes
Mar 7, 2025
DereC4
approved these changes
Mar 8, 2025
|
|
IsaDavRod
requested changes
Mar 8, 2025
Samathingamajig
approved these changes
Mar 8, 2025
Samathingamajig
dismissed
Razboy20’s stale review
approved by elie
Sam — Today at 3:38 PM
thats what i think too just wanted to throw that out there
@elie did you want to review this again or you fine? Both of your requested changes were addressed
Elie — Today at 3:39 PM
Looks good 👍
Sam — Today at 3:39 PM
k
Elie — Today at 3:39 PM
(on mobile)
|
sorry other elie for the ping, got unlucky with the copy/pasting having a name conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #529.
Implements the What's New popup
This creates a prompt that will show when the user opens the calendar view for the first time after the extension is updated or installed. The figma reference here.
Screenshot
TODO:
Make changelog button navigate to settings page(TBD due to github-fetching lag in the settings page)BUG: the dialog shouldn't reopen after opening the changelog(TBD might require changingDialog.tsx)This change is