Allow recompute via _make_file func
#1093
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran in to some issues here, being unable to replicate the DJ-stored file hash with seemingly matched contents. Need to do more testing on whether or not memory pointers are factored into the hash. If so, we may need to store a hash of the object computed by the specific table, and adjust the DJ-stored file hash on recreation |
edeno
reviewed
Feb 20, 2025
| raise FileNotFoundError( | ||
| f"Found {len(query)} files for: {analysis_nwb_file_name}" | ||
| ) | ||
| return f"{analysis_dir}/" + query.fetch1("filepath") |
There was a problem hiding this comment.
Probably be better to make this less file system dependent by using pathlib
| ) | ||
|
|
||
| external_tbl = schema.external["analysis"] | ||
| file_path = ( |
| @@ -317,6 +317,8 @@ def make(self, key): | |||
| recording = self._get_filtered_recording(key) | |||
| recording_name = self._get_recording_name(key) | |||
|
|
|||
| # recording_dir = Path("/home/cbroz/wrk/temp_ssr0/") | |||
| @@ -0,0 +1,257 @@ | |||
| """This schema is used to transition manage files for recompute. | |||
There was a problem hiding this comment.
This module could have a more descriptive name. recompute.py perhaps?
| self.file.close() | ||
|
|
||
| def remove_version(self, key: str) -> bool: | ||
| version_pattern = ( |
There was a problem hiding this comment.
I do worry a bit about these regex's failing. Versioning is hopefully pretty stable.
|
Just adding a reminder here to warn the lab before this gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to recompute when fetching a non-existent file from
v1.SpikeSortingRecording, adding some infrastructure to support expanding this tool in the future. To facilitate this, I add ..._make_filefunc that other tables can implement in the future.fetch_nwbI have tested these hashers for...
v1.SpikeSortingRecordingv0.SpikeSortingRecordingRaw(ongoing, so far 50%)Checklist:
CITATION.cffaltersnippet for release notes.CHANGELOG.mdwith PR number and description.Question
I found at least one file/directory where hashes mismatched across
What should we do about these? Do we need to restrict our deletions to only items replicable with an up-to-date Spyglass? Should I start building the infrastructure to compile this list? What do we want to do with files that don't replicate? Do we need to then do some experimentation with dependency versions? This might point us to adding conda env dumps to some part of this process