-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burst merge curation #1209
base: master
Are you sure you want to change the base?
Burst merge curation #1209
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
||
if fetch_all: | ||
waveform_params["max_spikes_per_unit"] = None | ||
waveforms_dir += "_all" # TODO: would it be better to overwrite? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted with Kyu: he's in favor of not overwriting
thanks for making these burst merging tables! |
@MichaelCoulter do you know if the burst merge calculation is working as expected? |
if query & f"unit1={unit2} AND unit2={unit1}": | ||
return unit1, unit2 | ||
elif query & f"unit1={unit1} AND unit2={unit2}": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self - looks like these restrictions should switch
i haven't checked the calculations against the old code that i used before. i can work on that. |
I understand the inconvenience, but I'd like to avoid merging anything that doesn't have the scientific stamp of approval. Arguably, instructing folks to pull from the master branch implies that anything there is ready for use. The counterarg would be that that implication should be reserved for published releases, but I still don't love putting something temporary like a username-prefix in the main branch I'll reach out over DM to you, Mike, to see if I can help alleviate the inconvenience of switching |
TODO:
MetricCuration