Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burst merge curation #1209

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Burst merge curation #1209

wants to merge 12 commits into from

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Jan 8, 2025

TODO:

  • Test V0 draft: here
  • Test V1 draft
  • Feedback on fix of combination bug, and indexing issues (1, 2)
  • First pass review to ensure scientifically aligned with previous work
  • Fix failing tests related to MetricCuration
  • Reduce redundancy across V0/V1 burst merge
  • Change schema names to add database instances
  • Add notebook demos for both V0/V1
  • Add pytests of this new work

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB


if fetch_all:
waveform_params["max_spikes_per_unit"] = None
waveforms_dir += "_all" # TODO: would it be better to overwrite?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with Kyu: he's in favor of not overwriting

@edeno edeno requested a review from MichaelCoulter February 7, 2025 19:49
@CBroz1 CBroz1 marked this pull request as ready for review February 10, 2025 15:14
@MichaelCoulter
Copy link
Collaborator

thanks for making these burst merging tables!
i tried the notebook and it worked for me. i also tried one of my entries in curationV1 and it also worked!
there is a calculation i would like to use, but i couldn't find it: i would like a count of the number of spikes from each unit that are shown in the cross correlogram plot. is there a way to get that? thanks.

@edeno
Copy link
Collaborator

edeno commented Feb 24, 2025

@MichaelCoulter do you know if the burst merge calculation is working as expected?

Comment on lines +417 to +419
if query & f"unit1={unit2} AND unit2={unit1}":
return unit1, unit2
elif query & f"unit1={unit1} AND unit2={unit2}":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self - looks like these restrictions should switch

@MichaelCoulter
Copy link
Collaborator

i haven't checked the calculations against the old code that i used before. i can work on that.
would it be possible to merge in this code to the main repo first? its hard for me to continue my other work and test this because i need to switch back and forth between the different repositories.

@CBroz1
Copy link
Member Author

CBroz1 commented Feb 24, 2025

merge in this code to the main repo first

I understand the inconvenience, but I'd like to avoid merging anything that doesn't have the scientific stamp of approval. Arguably, instructing folks to pull from the master branch implies that anything there is ready for use. The counterarg would be that that implication should be reserved for published releases, but I still don't love putting something temporary like a username-prefix in the main branch

I'll reach out over DM to you, Mike, to see if I can help alleviate the inconvenience of switching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants