Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported spike annotation #812

Merged
merged 13 commits into from
Feb 2, 2024
Merged

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Feb 1, 2024

Description

#ToDo:

  • Add method to annotate imported spike data
  • Append annotations to nwb when loading from ImportedSpikeSorting
  • Make SortedSpikesGroup downstream of SortingOutput again
  • Remove UnitInclusionOutput
  • filter units by inclusion parameters in SortedSpikesGroup.fetch_spike_data()
  • Test with multiple spikesorting pipelines
  • update notebooks

@edeno edeno requested a review from CBroz1 February 1, 2024 06:03
@CBroz1
Copy link
Member

CBroz1 commented Feb 1, 2024

Just a note that failing lint may be bc of the recent black v24 updates. I've updated the pre-commit file to reflect the gh-action linter's updated version

@CBroz1 CBroz1 mentioned this pull request Feb 1, 2024
4 tasks
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@edeno edeno marked this pull request as ready for review February 2, 2024 22:44
@edeno edeno merged commit 0f3aa17 into decoding-pipeline Feb 2, 2024
2 checks passed
@edeno edeno deleted the imported_spike_annotation branch February 2, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants