Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vue init #100

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Feat/vue init #100

merged 9 commits into from
Jan 12, 2024

Conversation

afsalz
Copy link
Collaborator

@afsalz afsalz commented Jan 11, 2024

Description

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This is something we need to do.

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: 519c29a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lottiefiles/dotlottie-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 85.48% / 85% 318 / 372
🟢 Statements 84.71% / 84% 327 / 386
🟢 Functions 86.41% / 86% 70 / 81
🟢 Branches 77.04% / 76% 188 / 244
File CoverageNo changed files found.
Generated in workflow #661

Copy link
Contributor

github-actions bot commented Jan 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 21.32 KB (0%) 427 ms (0%) 628 ms (-3.34% 🔽) 1.1 s
@lottiefiles/dotlottie-web WASM 104.43 KB (0%) 2.1 s (0%) 0 ms (+100% 🔺) 2.1 s
@lottiefiles/dotlottie-react 24.21 KB (0%) 485 ms (0%) 811 ms (+19.13% 🔺) 1.3 s
@lottiefiles/dotlottie-wc 31.63 KB (0%) 633 ms (0%) 578 ms (+5.34% 🔺) 1.3 s
@lottiefiles/dotlottie-vue 28.76 KB (+100% 🔺) 576 ms (+100% 🔺) 969 ms (+100% 🔺) 1.6 s

Copy link
Member

@theashraf theashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include dotlottie-vue in the .size-limit.cjs config

{
    name: '@lottiefiles/dotlottie-vue',
    path: 'packages/vue/dist/index.js',
    import: '*',
    modifyWebpackConfig,
  },

@afsalz afsalz requested a review from theashraf January 12, 2024 06:51
Copy link
Member

@theashraf theashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@theashraf theashraf merged commit 079cc00 into main Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants