Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 webp support #133

Merged
merged 5 commits into from
Feb 15, 2024
Merged

feat: 🎸 webp support #133

merged 5 commits into from
Feb 15, 2024

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Feb 15, 2024

Description

  • Update dotlottie-rs wasm bindings which has the thorvg webp support
  • Replace the vitest browser from chrome to firefox as it's failing to download the chromedriver
ERROR webdriver: Failed downloading chromedriver v121.0.6167.184: Download failed: server returned code 404. URL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/121.0.6167.184/linux64/chromedriver-linux64.zip, retrying .

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This is something we need to do.

Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: 366a4df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@lottiefiles/dotlottie-web Minor
@lottiefiles/dotlottie-react Patch
@lottiefiles/dotlottie-vue Patch
@lottiefiles/dotlottie-wc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 15, 2024

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 87.64% / 87% 227 / 259
🟢 Statements 84.15% / 84% 239 / 284
🟢 Functions 84.72% / 84% 61 / 72
🟢 Branches 76.66% / 76% 161 / 210
File CoverageNo changed files found.
Generated in workflow #795

@theashraf theashraf added enhancement New feature or request web labels Feb 15, 2024
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 13.84 KB (+0.01% 🔺) 277 ms (+0.01% 🔺) 40 ms (+37.07% 🔺) 317 ms
@lottiefiles/dotlottie-web WASM 287.09 KB (+10.09% 🔺) 5.8 s (+10.09% 🔺) 0 ms (+100% 🔺) 5.8 s
@lottiefiles/dotlottie-react 17.73 KB (0%) 355 ms (0%) 47 ms (+160.09% 🔺) 402 ms
@lottiefiles/dotlottie-vue 21.23 KB (+0.01% 🔺) 425 ms (+0.01% 🔺) 49 ms (+84.9% 🔺) 473 ms
@lottiefiles/dotlottie-wc 22.37 KB (0%) 448 ms (0%) 43 ms (-4.27% 🔽) 490 ms

@theashraf theashraf merged commit 7f659f7 into main Feb 15, 2024
2 checks passed
@theashraf theashraf deleted the fix/webp branch March 18, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants