Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new getter functions to RFM69 and RFM69 ATC #195

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

brainelectronics
Copy link
Contributor

  • getVersion() to read RFM version
  • getAddress() to return configured node ID
  • getNetwork() to return configured network ID
  • getFrequencyDeviation() to read frequency deviation
  • getBitRate() to read the modulation bitrate in bits/second
  • getSpyMode() to return spy mode setting
  • isSyncOn()
  • getSyncSize()
  • isCrcOn() to check if CRC is activated
  • isAesOn() to check if encryption is enabled
  • isHighPower() to check if module is configured as HCW or not
  • dBm_to_mW() to convert dBm to mW
  • getOutputPower() to get the configured output power instead of returning the last
  • getTargetRssi() to get the configured RSSI value, only for RFM69_ATC
  • _networkID made public to get it via getNetwork() function

Plus the demo sketch Examples/TestSetup/TestSetup.ino to showcase the usage of all available getter functions

- getVersion() to read RFM version
- getAddress() to return configured node ID
- getNetwork() to return configured network ID
- getFrequencyDeviation() to read frequency deviation
- getBitRate() to read the modulation bitrate in bits/second
- getSpyMode() to return spy mode setting
- isSyncOn()
- getSyncSize()
- isCrcOn() to check if CRC is activated
- isAesOn() to check if encryption is enabled
- isHighPower() to check if module is configured as HCW or not
- dBm_to_mW() to convert dBm to mW
- getOutputPower() to get the configured output power instead of returning the last set value
- getTargetRssi() to get the configured RSSI value, only for RFM69_ATC
- `_networkID` made public to get it via getNetwork() function
@LowPowerLab
Copy link
Owner

@brainelectronics - Thanks for submitting this, I appreciate the leg work and reformatting and prettifying the lib a bit, I've been trying to dedicate some time to test the changes, check compilation, performance, ensure compatibility etc, since this is so impactful to current and future deployments. I will follow up once my review is complete.
Regarding the version - the getter yields the silicon version rather than the library - which is currently set in library.json and library.properties files. Any thoughts how to pull that into the lib?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants