Fix Invalid delayed_option #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is to be implemented by every child of the notification class. It's porpuse is to add each notification type specific data to be sent. Also the get_data method was move to the parent class notification this will allow general behavior to be defined. In this case, for some reason, the field delayed_option should no be sent if not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10
This happends cause some fields, if sent, must contain a value. I created a global list to hold these type of fields for future cases.
The method
get_instance_datais to be implemented by every child of the notification class. It's porpuse is to add each notification type specific data to be sent.Also the get_data method was move to the parent class notification this will allow general behavior to be defined. In this case, for some reason, the field
delayed_optionshould no be sent if not set.