Expanding NormedPerson interface to class #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves load from CSV logic closer to the data structure interface. And while it doesn't check off all of the TODO items for #137, it helps tidy up the code base. I'm going to be reviewing the details of those checkbox items, as I'm unclear the purpose (e.g. For example, writing the data structure to CSV)
rmakhija94
pushed a commit
that referenced
this pull request
Apr 18, 2023
Expanding NormedPerson interface to class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves load from CSV logic closer to the data structure
interface.
And while it doesn't check off all of the TODO items for #137, it helps
tidy up the code base.
I'm going to be reviewing the details of those checkbox items, as I'm
unclear the purpose (e.g. For example, writing the data structure to CSV)