-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
1b654f6
commit 53d332e
Showing
8 changed files
with
15 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
/** | ||
* vModal - Simple, flexible and beautiful modal dialogs in AngularJS | ||
* @version v1.1.0 | ||
* @version v1.1.1 | ||
* @link http://lukaszwatroba.github.io/v-modal | ||
* @author Łukasz Wątroba <[email protected]> | ||
* @license MIT License, http://www.opensource.org/licenses/MIT | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
/** | ||
* vModal - Simple, flexible and beautiful modal dialogs in AngularJS | ||
* @version v1.1.0 | ||
* @version v1.1.1 | ||
* @link http://lukaszwatroba.github.io/v-modal | ||
* @author Łukasz Wątroba <[email protected]> | ||
* @license MIT License, http://www.opensource.org/licenses/MIT | ||
|
@@ -148,8 +148,7 @@ function vModalDirective () { | |
throw new Error('Expected modal to have exacly one of either `template` or `templateUrl`'); | ||
} | ||
|
||
var template = config.template, | ||
controller = config.controller || null, | ||
var controller = config.controller || null, | ||
controllerAs = config.controllerAs, | ||
container = angular.element(config.container || $document[0].querySelector(modalConfig.containerSelector)), | ||
element = null, | ||
|
@@ -179,7 +178,7 @@ function vModalDirective () { | |
function attach (html, locals) { | ||
element = angular.element(html); | ||
if (element.length === 0) { | ||
throw new Error('The template contains no elements; you need to wrap text nodes') | ||
throw new Error('The template contains no elements; you need to wrap text nodes'); | ||
} | ||
scope = $rootScope.$new(); | ||
if (controller) { | ||
|
@@ -210,6 +209,7 @@ function vModalDirective () { | |
scope = null; | ||
element.remove(); | ||
element = null; | ||
container.removeAttr('v-modal-open'); | ||
}); | ||
} | ||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"name": "v-modal", | ||
"description": "vModal - Simple, flexible and beautiful modal dialogs in AngularJS", | ||
"version": "1.1.0", | ||
"version": "1.1.1", | ||
"author": "Łukasz Wątroba <[email protected]>", | ||
"license": "MIT", | ||
"keywords": [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters