AMP Library upgrade #248
Open
AMP Library upgrade #248
+17,195
−7,101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcelovani I see you have been working on ways to upgrade this library or create a new one. I'm glad to see you doing this. I was wondering myself about whether the Wordpress plugin could be an opportunity to do this better. I'm curious which path you think has the most promise, trying to resurrect this library or starting over? I've been too busy to help much but am supportive of what you're doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the amp library up to date with the latest ampproject/amphtml code
The
validator-generated.phpfile was generated using this fork https://github.com/marcelovani/amphtml/tree/marc-generatorThe fork is up to date with ampproject/amphtml
We are waiting for Lullabot/amphtml#7 to be merged first to then issue a pr for the php-validator-generated branch