Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update phpstan packages to v2 (major) #737

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 11, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
mglaman/phpstan-drupal ^1.3.2 -> ^2.0.0 age adoption passing confidence
phpstan/phpstan-deprecation-rules ^1.2.1 -> ^2.0.1 age adoption passing confidence

Release Notes

mglaman/phpstan-drupal (mglaman/phpstan-drupal)

v2.0.0

Compare Source

What's Changed

New Contributors

Full Changelog: mglaman/phpstan-drupal@1.3.1...2.0.0

phpstan/phpstan-deprecation-rules (phpstan/phpstan-deprecation-rules)

v2.0.1

Compare Source

  • 1cc1259 - Bleeding edge - CallWithDeprecatedIniOptionRule

v2.0.0

Compare Source

  • 81833b5 - Removed always true PHP_VERSION_ID condition
  • f4a969d - Merge branch '1.2.x' into 2.0.x
  • 0ccccb1 - selectSingle() is being deprecated
  • 392bbe7 - Updates for PHPStan 2.0 changes
  • 89572d5 - Merge branch '1.2.x' into 2.0.x
  • 398e2e2 - Merge remote-tracking branch 'origin/1.2.x' into 2.0.x
  • 4590cf6 - Update build-cs
  • 681b2db - Stop testing PHP 7.2 and 7.3
  • 0e1d78a - Open 2.0.x

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/major-phpstan-packages branch from 945c33a to b0d1e1b Compare November 28, 2024 22:11
@renovate renovate bot force-pushed the renovate/major-phpstan-packages branch from b0d1e1b to f945bcd Compare December 11, 2024 18:29
@renovate renovate bot changed the title fix(deps): update dependency phpstan/phpstan-deprecation-rules to v2 fix(deps): update phpstan packages to v2 (major) Dec 11, 2024
@github-actions github-actions bot temporarily deployed to pantheon-pr-737 December 11, 2024 18:31 Destroyed
@renovate renovate bot force-pushed the renovate/major-phpstan-packages branch from f945bcd to 448c20a Compare December 11, 2024 18:42
@mrdavidburns
Copy link
Member

@justafish Thoughts about merging this? I see it removes checks for PHP 7.2 and 7.3.
My hesitation is that it could identify new deprecations and cause checks to fail where they were once passing so this feels like a breaking change (hence the major version release).

How do we handle updates like this?
When is the right time to merge it?

@github-actions github-actions bot temporarily deployed to pantheon-pr-737 December 11, 2024 18:45 Destroyed
@mrdavidburns mrdavidburns merged commit c563286 into main Jan 13, 2025
53 checks passed
@mrdavidburns mrdavidburns deleted the renovate/major-phpstan-packages branch January 13, 2025 14:14
@mrdavidburns
Copy link
Member

Reviewed during Drainpipe weekly sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant