Exclude include fixer from twigcsfixer #758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+35
to
+36
| // Remove the IncludeFunctionRule which breaks TwigJS. | ||
| $ruleset->removeRule(TwigCsFixer\Rules\Function\IncludeFunctionRule::class); |
There was a problem hiding this comment.
Is it possible to do this by committing .twig-cs-fixer.php to your local repo? Then you could control this and anything else (since this twigjs isn't commonly used).
There was a problem hiding this comment.
Agreed. This would be a good thing to just document over changing drainpipe... that is, assuming drainpipe doesn't overwrite files that are present, or the scaffolding can be controlled in composer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Include function from the TwigCSFixer which causes issues in Storybook.