-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace Animation Library to Reanimated #77
Conversation
Ohhh this is actually so nice! Can't wait to take a better look at it. Hopefully it will be this weekend or the next. 🙈 |
requires react-native-reanimated v2 or later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test the changes yet, nor did I have a closer look at the code, but I'm wondering how much effort would require to keep both implementations by having a withReanimated: boolean
prop. 🤔 I think that letting the users choose between the two it's the best way to go, of course only if that's possible.
I completely agree with you and hope so. |
Will test the changes, then I will try to merge everything together so it can play nicely with or without |
Tested, changes look good. Trying to find a way to implement a |
Merging this for now, however, I think I will extract your logic in a separate package and let the user decide if what he wants to use it for the animations. |
1 similar comment
Merging this for now, however, I think I will extract your logic in a separate package and let the user decide if what he wants to use it for the animations. |
@goheroes I extracted your logic into |
Apply Reanimated for UI/UX experiences