fix: remove type pirated functions from Lux

LuxDL · Aug 11, 2024 · c42afde · c42afde
1 parent 4d5c9cb
commit c42afde
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 42 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Lux"
 uuid = "b2108857-7c20-44ae-9111-449ecde12c47"
 authors = ["Avik Pal <[email protected]> and contributors"]
-version = "0.5.63"
+version = "0.5.64-DEV"
 
 [deps]
 ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
@@ -86,7 +86,7 @@ Functors = "0.4.12"
 GPUArraysCore = "0.1.6"
 LinearAlgebra = "1.10"
 LossFunctions = "0.11.1"
-LuxCore = "0.1.16"
+LuxCore = "0.1.24"
 LuxDeviceUtils = "0.1.26"
 LuxLib = "0.3.40"
 MLUtils = "0.4.3"

diff --git a/ext/LuxReverseDiffExt/LuxReverseDiffExt.jl b/ext/LuxReverseDiffExt/LuxReverseDiffExt.jl
@@ -9,7 +9,6 @@ using LuxCore: LuxCore, AbstractExplicitLayer
 using ReverseDiff: ReverseDiff, ForwardExecutor, ReverseExecutor, TrackedArray, TrackedReal,
                    @grad_from_chainrules
 
-include("apply.jl")
 include("utils.jl")
 include("rules.jl")
 include("training.jl")

diff --git a/ext/LuxReverseDiffExt/apply.jl b/ext/LuxReverseDiffExt/apply.jl
diff --git a/ext/LuxTrackerExt/LuxTrackerExt.jl b/ext/LuxTrackerExt/LuxTrackerExt.jl
@@ -10,7 +10,6 @@ using Tracker: Tracker, TrackedArray, TrackedReal, @grad_from_chainrules
 
 const CRC = ChainRulesCore
 
-include("apply.jl")
 include("utils.jl")
 include("rules.jl")
 include("training.jl")

diff --git a/ext/LuxTrackerExt/apply.jl b/ext/LuxTrackerExt/apply.jl
diff --git a/src/chainrules.jl b/src/chainrules.jl
@@ -71,14 +71,6 @@ function CRC.rrule(cfg::RuleConfig{>:HasReverseMode}, ::typeof(foldl_init),
     return y, ∇foldl_init
 end
 
-# getproperty rrule for AbstractExplicitLayer. needed for type stability of Zygote
-# gradients
-function CRC.rrule(::typeof(getproperty), m::AbstractExplicitLayer, name::Symbol)
-    res = getproperty(m, name)
-    ∇getproperty = Δ -> ntuple(Returns(NoTangent()), 3)
-    return res, ∇getproperty
-end
-
 # Loss Functions
 @inline function CRC.rrule(
         ::typeof(__fused_agg), ::typeof(sum), lfn::LossFunctions.Traits.Loss, x, y)