fix: preserve object when device is same #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (5)
- lib/MLDataDevices/ext/MLDataDevicesAMDGPUExt.jl: Language not supported
- lib/MLDataDevices/ext/MLDataDevicesCUDAExt.jl: Language not supported
- lib/MLDataDevices/ext/MLDataDevicesMetalExt.jl: Language not supported
- lib/MLDataDevices/ext/MLDataDevicesoneAPIExt.jl: Language not supported
- lib/MLDataDevices/src/public.jl: Language not supported
Benchmark Results (ASV)
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
avik-pal
added a commit
that referenced
this pull request
Dec 20, 2024
* fix: preserve object when device is same * test: object not copied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
MLDataDevicespackage, focusing on improving the device transfer functionality for various device types. The changes involve modifying theAdapt.adapt_storagemethod to ensure that the device type is checked before performing a transfer.Updates to device transfer functionality:
lib/MLDataDevices/ext/MLDataDevicesAMDGPUExt.jl: Updated theAdapt.adapt_storagemethod forAMDGPUDeviceto check the device type before transferring.lib/MLDataDevices/ext/MLDataDevicesCUDAExt.jl: Updated theAdapt.adapt_storagemethod forCUDADeviceto check the device type before transferring.lib/MLDataDevices/ext/MLDataDevicesMetalExt.jl: Updated theAdapt.adapt_storagemethod forMetalDeviceto check the device type before transferring.lib/MLDataDevices/ext/MLDataDevicesoneAPIExt.jl: Updated theAdapt.adapt_storagemethod foroneAPIDeviceto check the device type before transferring. [1] [2]lib/MLDataDevices/src/public.jl: Updated theAdapt.adapt_storagemethod forCPUDeviceto check the device type before transferring.Additionally, the package version has been incremented to
1.6.4in theProject.tomlfile.fixes #1129