This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
drop Lux "branding" #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
===========================================
- Coverage 85.81% 38.72% -47.10%
===========================================
Files 13 13
Lines 289 297 +8
===========================================
- Hits 248 115 -133
- Misses 41 182 +141 ☔ View full report in Codecov by Sentry. |
avik-pal
reviewed
Jul 10, 2024
avik-pal
reviewed
Jul 10, 2024
|
not sure why coverage dropped |
Buildkite doesn't give forks access to secrets. That is fine, I can open a PR from your branch and it will work |
|
Overall looks good, I will pull it into #53 and merge as 1.0 once the other packages are also ready for the tag. |
avik-pal
reviewed
Jul 10, 2024
avik-pal
reviewed
Jul 10, 2024
avik-pal
reviewed
Jul 10, 2024
CarloLucibello
commented
Jul 12, 2024
|
should I rebase? |
|
Yeah do a rebase. But I will merge this together with the 1.0 pr |
cleanup cleanup fix improve docstring require cuDNN none functional only if cuDNN is functional separate cuDNN extension cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #51
Some comments
using CUDA, cuDNNorusing LuxCUDA.