Add Bizimodu Baten Historia by Iskanbila #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this! #984 just whitelisted "Basque" as a valid value for the Language metadata key, please feel free to rebase your commit against upstream, it's in Seems like the files need a newline at the end, it's failing that test. |
|
Thanks, could you whitelist "Spanish" too? One of the songs it's in Spanish but the formatting was wrong and I think it didn't get detected (I'm fixing the format). |
|
Please feel free to add it here https://github.com/Lyrics/lyrics-database/blob/master/tests/database-tests.d/4-metadata.py#L95 |
antaanimosity
force-pushed
the
iskanbila-bizimodubatenhistoria
branch
from
fd43766 to
422222e
Compare
|
It's been merged and published on the website. Thank you once again for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.