Merge pull request scnu-socoding#152 from M1saka10010/master

fix: judger code quality
M1saka10010 · Jan 27, 2024 · 4f9dc26 · 4f9dc26
2 parents a6f8813 + 8f842be
commit 4f9dc26
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/judge/src/judge.c b/judge/src/judge.c
@@ -138,7 +138,8 @@ void write_log(const char *fmt, ...)
     va_list ap;
     char buffer[BUFFER_SIZE];
     // sprintf(buffer, "%s/log/client.log", oj_home);
-    if (snprintf(buffer, BUFFER_SIZE, "%s/log/client.log", oj_home) < 0)
+    int snp = snprintf(buffer, BUFFER_SIZE, "%s/log/client.log", oj_home);
+    if (snp < 0 || snp >= BUFFER_SIZE)
     {
         write_log("buffer overflow");
     }

diff --git a/polygon/src/judge.c b/polygon/src/judge.c
@@ -122,9 +122,6 @@ void write_log(const char *fmt, ...)
     {
         write_log("buffer overflow!");
     }
-    {
-        write_log("buffer overflow!");
-    }
     FILE *fp = fopen(buffer, "ae+");
     if (fp == NULL)
     {