-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scalene CPU+mem profiling #4
Conversation
Adding `conda` as a dependency fixes the "command not found" error when `dem` is the activated env.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
BTW, I registered |
@nemo794, although the total amount of code is small, I made significant changes, so I'd be happy to pair up with you to go over them, if you like. |
Hi @chuckwondo , That'd be great. |
@nemo794, I've sent you a DM in the Slack ESA-NASA MAAP workspace regarding my availability. |
Closing this PR after @nemo794 and I discussed the need to break it into smaller pieces, and also the need to wait for other PRs to land first, in order to support better coordination between NASA and ESA. |
@chuckwondo can you be more specific, are you waiting for #2 to happen first? |
Sorry, yes, waiting for #2 to happen first. Also, @nemo794 and I discovered that the call out to Once #2 lands, Sam and I will work on creating a small, focused PR to get |
Here's what I did:
time
within the code. This produces a profiling report namedprofile.html
in the algorithm's output directory.algorithm_config.yml
to the repo to enable programmatic algorithm registration. Note that prior to each release, the value ofalgorithm_version
should be changed appropriately, in sync with changingget_dem.__version__
as well, prior to registration, in order for a new version to be registered. Registration should likely occur after merging the bumped versions intodevelop
and taggingdevelop
with the version value as well.Fixes #1