Remove need environmentsjson #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjo-luc
reviewed
Dec 4, 2024
bsatoriu
reviewed
Dec 4, 2024
|
|
Added error handling and passing checks Tested that when I purposely do the wrong environments.json file path, the API gives a 500 error |
marjo-luc
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://raw.githubusercontent.com/MAAP-Project/maap-jupyter-ide/develop/maap_environments.json was giving a 403 when the API tried to access it
Instead, I added the environments.json file to this repository. I think if we need to maintain this file on git, then this repo makes the most sense
The API can now access the environments.json correctly
I don't see any reason to continue having
MAAP_ENVIRONMENT_FILEin the api/settings.py and it does not seem to be mentioned anywhere else https://github.com/search?q=org%3AMAAP-Project%20MAAP_ENVIRONMENT_FILE&type=codeRelated to: MAAP-Project/Community#1055