added pagination to listJobs endpoint

[marjo-luc]

Added optional pagination parameters to listJobs endpoint. Sample maap-py calls and their corresponding MAAP API requests:

r = maap.listJobs("mlucas") : https://api.dit.maap-project.org/api/dps/job/mlucas/list

r = maap.listJobs("mlucas", 20, 10) : https://api.dit.maap-project.org/api/dps/job/mlucas/list?page_size=20&offset=10

Work needed for this ticket

[chuckwondo]

You should not be manually adding query params to a URL. The requests library properly deals with them, including doing proper encoding. Simply construct a params dict and pass it as an additional named argument to requests.get:

Suggested change

	query_params = []
	if page_size is not None:
	query_params.append(f"page_size={page_size}")
	if offset is not None:
	query_params.append(f"offset={offset}")
	query_string = "&".join(query_params)
	if query_string:
	endpoint = endpoints.DPS_JOB_LIST + "?" + query_string
	url = os.path.join(self.config.dps_job, username, endpoint)
	else:
	url = os.path.join(self.config.dps_job, username, endpoints.DPS_JOB_LIST)
	url = os.path.join(self.config.dps_job, username, endpoints.DPS_JOB_LIST)
	params = {k: v for k, v in (("page_size", page_size), ("offset", offset)) if v}

And then, change the call to requests.get that follows, to this:

        response = requests.get(
            url=url,
            headers=headers,
            params=params,
        )

[chuckwondo]

Any chance of filling in a unit test? https://github.com/MAAP-Project/maap-py/blob/master/test/test_DPS.py#L55-L56

[marjo-luc]

I created #97 to implement the unit test method stubs. It looks like there's more work needed to get this into a functional state as well (removing maap.cfg reference and mocking the API), which falls out of scope of this ticket.

[chuckwondo]

lgtm!