Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update depth-dependent ice-shelf basal melt parameterization and add variability input field #103
base: develop
Are you sure you want to change the base?
Update depth-dependent ice-shelf basal melt parameterization and add variability input field #103
Changes from 15 commits
07cac84
cfe4264
8611707
b64b61b
8f9f6cb
9f124fc
2dc1067
bb469c4
b9c50e3
ec75f7a
dce872d
9b3cdd0
23440c8
c884a25
0e3a4fb
f50f131
b3c1eb0
50abf8d
a84cd6a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear what the difference is between
floatingBasalMassBalAdjustment
anddraftDepenBasalMeltAlpha0
. The descriptions need more detail. For which cases isfloatingBasalMassBalAdjustment
used?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, they are similar in that they are both added to the product of
draft
anddraftDepenBasalMeltAlpha1
. Main difference is thatdraftDepenBasalMeltAlpha0
(anddraftDepenBasalMeltAlpha1
) is time independent whilefloatingBasalMassBalAdjustment
can be time dependent, with the latter being read in via a forcing file input stream.draftDepenBasalMeltAlpha0
anddraftDepenBasalMeltAlpha1
are maps derived via a regression of basal melt with draft.floatingBasalMassBalAdjustment
is treated as an optional additional basal melt forcing value - in the context of the AISLENS experiments, it includes time varying basal melt forcing that can have secular/seasonal trends and variability, or a combination of them. Will update the main description above as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be completely accurate, this should probably treat dynamic and non-dynamic cells differently. Melt rates for non-dynamic cells should probably be calculated using the draft values from neighboring dynamic cells. @matthewhoffman, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably be doing that, but if we include that, it should probably be done for all melt options. Looks like we sort of say we are doing that at line 586 but it's not actually doing it. Or maybe it should happen where BMB is actually applied, using the dynamic mask that exists at that point. I think that should be a separate PR, given it would change the application of all melt rate methods.