Add config slm restart #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollyhan
added
enhancement
hollyhan
force-pushed
the
add_config_slm_restart
branch
from
2d36953 to
eac8eff
Compare
| description="Time interval at which the sea-level model is called by MALI. The interval has to be an even multiple of the option 'config_adaptive_timestep_force_interval" | ||
| possible_values="Any time interval of the format 'YYYY-MM-DD_HH:MM:SS'" | ||
| /> | ||
| <nml_option name="config_slm_restart" type="logical" default_value=".false." units="unitless" |
There was a problem hiding this comment.
@hollyhan , can you use the standard config_do_restart flag for this, so as not to need two restart flags?
|
Closing the PR and creating a new one (#99) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when the regional sea-level prediction capability was added to MALI (#21), the restart config option for the sea-level model was not added. This led the sea-level model to get initialized to the timestep zero when coupled MALI-SLM simulations are being restarted, forgetting about the ice loading changes that happened in previous timesteps. This PR fills in that gap by adding a config option and other changes such sea-level model can resume where it was left off, and the sea-level model captures the signals associated with ice loading changes since the beginning of the simulations.
Note: this PR is in progress as of 04/12/2023