ci: fix github actions

.github/workflows/actions/export-ios-archive/action.yml

@@ -30,6 +30,6 @@ runs:
       uses: actions/upload-artifact@v4
       with:
         name: ${{ inputs.ouput_artifact_ref }}
-        path: export/BCWallet.ipa
+        path: export/PortefeuilleQc.ipa
         if-no-files-found: error
         retention-days: 1

.github/workflows/actions/run-test-harness/action.yml

@@ -17,7 +17,7 @@ inputs:
     required: true
     default: "-w bc_wallet"
   BUILD_NAME:
-    description: "Build Name eg. -b BCWallet.ipa"
+    description: "Build Name eg. -b QCWallet.ipa"
     required: false
     default: ""
   ISSUER_AGENT:

.github/workflows/main.yaml

@@ -37,7 +37,7 @@ jobs:
             "KEYCHIAN_PASSWD"
             "PROVISIONING_PROFILE"
             "PLAY_STORE_JKS_BASE64"
-            "PLAY_STORE_JSK_ALIAS"
+            "PLAY_STORE_JKS_ALIAS"
             "PLAY_STORE_JKS_PASSWD"
           )
           for var in "${required_env_vars[@]}"; do
@@ -165,9 +165,10 @@ jobs:
           echo "OCA_URL=${OCA_URL}" >>.env
 
       - name: Update APS environment
+        working-directory: app/ios/AriesBifold
         run: |
-          sed -i '' 's/development/production/g' app/ios/AriesBifold/AriesBifold.entitlements
-          cat app/ios/AriesBifold/AriesBifold.entitlements
+          sed -i '' 's/development/production/g' AriesBifold.entitlements
+          cat AriesBifold.entitlements
 
       - name: Create prod signing credentials
         uses: ./.github/workflows/actions/create-ios-sig-creds
@@ -215,7 +216,7 @@ jobs:
           version_name: ${{ env.appBuildVersion }}
 
   build-android:
-    needs: [check-android-secrets]
+    needs: [check-secrets, check-vars]
     runs-on: ubuntu-22.04
     permissions:
       contents: read
@@ -338,7 +339,7 @@ jobs:
           node ./deploy-to-playstore.js 
 
   release:
-    if: github.ref_name == 'main' && needs.check-android-secrets.outputs.isReleaseBuild == 'true' && needs.check-ios-secrets.outputs.isReleaseBuild == 'true'
+    if: github.ref_name == 'main' 
     needs: [build-ios, build-android]
     runs-on: ubuntu-latest
     steps:
@@ -399,7 +400,7 @@ jobs:
           echo "ANDROID_APP_URL=lt://$(jq -r '.app_id' $HOME/lt_android_resp.json)" >> "$GITHUB_OUTPUT"
 
   run-on-device-tests:
-    if: github.ref_name == 'main' && needs.check-android-secrets.outputs.isReleaseBuild == 'true' && needs.check-ios-secrets.outputs.isReleaseBuild == 'true'
+    if: github.ref_name == 'main' 
     needs: [ship-to-lambdatest]
     runs-on: ubuntu-22.04
     strategy:

app/app.json

@@ -1,4 +1,4 @@
 {
-  "name": "QCWallet",
+  "name": "PortefeuilleQc",
   "displayName": "Portefeuille QC"
 }

app/ios/AriesBifold/AppDelegate.m

@@ -11,7 +11,7 @@ @implementation AppDelegate
 - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
 
   RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
-  RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge moduleName:@"QCWallet" initialProperties:nil];
+  RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge moduleName:@"PortefeuilleQc" initialProperties:nil];
 
   if (@available(iOS 13.0, *)) {
       rootView.backgroundColor = [UIColor systemBackgroundColor];	

app/ios/AriesBifold/Info.plist

@@ -1,98 +1,98 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
+<dict>
+	<key>CFBundleDevelopmentRegion</key>
+	<string>fr</string>
+	<key>CFBundleDisplayName</key>
+	<string>Portefeuille QC</string>
+	<key>CFBundleExecutable</key>
+	<string>$(EXECUTABLE_NAME)</string>
+	<key>CFBundleIdentifier</key>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
+	<key>CFBundleInfoDictionaryVersion</key>
+	<string>6.0</string>
+	<key>CFBundleName</key>
+	<string>$(PRODUCT_NAME)</string>
+	<key>CFBundlePackageType</key>
+	<string>APPL</string>
+	<key>CFBundleShortVersionString</key>
+	<string>$(MARKETING_VERSION)</string>
+	<key>CFBundleSignature</key>
+	<string>????</string>
+	<key>CFBundleURLTypes</key>
+	<array>
+		<dict>
+			<key>CFBundleURLSchemes</key>
+			<array>
+				<string>qcwallet</string>
+			</array>
+		</dict>
+		<dict>
+			<key>CFBundleURLSchemes</key>
+			<array>
+				<string>didcomm</string>
+			</array>
+		</dict>
+	</array>
+	<key>CFBundleVersion</key>
+	<string>$(CURRENT_PROJECT_VERSION)</string>
+	<key>ITSAppUsesNonExemptEncryption</key>
+	<false/>
+	<key>LSApplicationQueriesSchemes</key>
+	<array>
+		<string>ca.qc.gouv.portefeuillemobileqc</string>
+	</array>
+	<key>LSRequiresIPhoneOS</key>
+	<true/>
+	<key>NSAppTransportSecurity</key>
 	<dict>
-		<key>CFBundleDevelopmentRegion</key>
-		<string>fr</string>
-		<key>CFBundleDisplayName</key>
-		<string>Portefeuille QC</string>
-		<key>CFBundleExecutable</key>
-		<string>$(EXECUTABLE_NAME)</string>
-		<key>CFBundleIdentifier</key>
-		<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
-		<key>CFBundleInfoDictionaryVersion</key>
-		<string>6.0</string>
-		<key>CFBundleName</key>
-		<string>$(PRODUCT_NAME)</string>
-		<key>CFBundlePackageType</key>
-		<string>APPL</string>
-		<key>CFBundleShortVersionString</key>
-		<string>$(MARKETING_VERSION)</string>
-		<key>CFBundleSignature</key>
-		<string>????</string>
-		<key>CFBundleURLTypes</key>
-		<array>
-			<dict>
-				<key>CFBundleURLSchemes</key>
-				<array>
-					<string>qcwallet</string>
-				</array>
-			</dict>
-			<dict>
-				<key>CFBundleURLSchemes</key>
-				<array>
-					<string>didcomm</string>
-				</array>
-			</dict>
-		</array>
-		<key>CFBundleVersion</key>
-		<string>$(CURRENT_PROJECT_VERSION)</string>
-		<key>ITSAppUsesNonExemptEncryption</key>
-		<false/>
-		<key>LSRequiresIPhoneOS</key>
+		<key>NSAllowsArbitraryLoads</key>
 		<true/>
-		<key>LSApplicationQueriesSchemes</key>
-		<array>
-			<string>ca.qc.gouv.id.servicescard</string>
-		</array>
-		<key>NSAppTransportSecurity</key>
+		<key>NSExceptionDomains</key>
 		<dict>
-			<key>NSAllowsArbitraryLoads</key>
-			<true/>
-			<key>NSExceptionDomains</key>
+			<key>localhost</key>
 			<dict>
-				<key>localhost</key>
-				<dict>
-					<key>NSExceptionAllowsInsecureHTTPLoads</key>
-					<true/>
-				</dict>
+				<key>NSExceptionAllowsInsecureHTTPLoads</key>
+				<true/>
 			</dict>
 		</dict>
-		<key>NSCameraUsageDescription</key>
-		<string>Camera used for in-app QR Code scanning</string>
-		<key>NSFaceIDUsageDescription</key>
-		<string>$(PRODUCT_NAME) wants to use your FaceID/TouchID to authenticate your identity</string>
-		<key>NSLocationWhenInUseUsageDescription</key>
-		<string>We include this permission because a library our app uses references it, even though we don't use it directly.</string>
-		<key>UIAppFonts</key>
-		<array>
-			<string>MaterialIcons.ttf</string>
-			<string>MaterialCommunityIcons.ttf</string>
-			<string>BCSans-Bold.ttf</string>
-			<string>BCSans-BoldItalic.ttf</string>
-			<string>BCSans-Italic.ttf</string>
-			<string>BCSans-Regular.ttf</string>
-		</array>
-		<key>UILaunchStoryboardName</key>
-		<string>LaunchScreen</string>
-		<key>UIRequiredDeviceCapabilities</key>
-		<array>
-			<string>armv7</string>
-		</array>
-		<key>UIRequiresFullScreen</key>
-		<true/>
-		<key>UISupportedInterfaceOrientations</key>
-		<array>
-			<string>UIInterfaceOrientationPortrait</string>
-		</array>
-		<key>UISupportedInterfaceOrientations~ipad</key>
-		<array>
-			<string>UIInterfaceOrientationLandscapeLeft</string>
-			<string>UIInterfaceOrientationLandscapeRight</string>
-			<string>UIInterfaceOrientationPortrait</string>
-			<string>UIInterfaceOrientationPortraitUpsideDown</string>
-		</array>
-		<key>UIViewControllerBasedStatusBarAppearance</key>
-		<false/>
 	</dict>
-</plist>
+	<key>NSCameraUsageDescription</key>
+	<string>Camera used for in-app QR Code scanning</string>
+	<key>NSFaceIDUsageDescription</key>
+	<string>$(PRODUCT_NAME) wants to use your FaceID/TouchID to authenticate your identity</string>
+	<key>NSLocationWhenInUseUsageDescription</key>
+	<string>We include this permission because a library our app uses references it, even though we don't use it directly.</string>
+	<key>UIAppFonts</key>
+	<array>
+		<string>MaterialIcons.ttf</string>
+		<string>MaterialCommunityIcons.ttf</string>
+		<string>BCSans-Bold.ttf</string>
+		<string>BCSans-BoldItalic.ttf</string>
+		<string>BCSans-Italic.ttf</string>
+		<string>BCSans-Regular.ttf</string>
+	</array>
+	<key>UILaunchStoryboardName</key>
+	<string>LaunchScreen</string>
+	<key>UIRequiredDeviceCapabilities</key>
+	<array>
+		<string>armv7</string>
+	</array>
+	<key>UIRequiresFullScreen</key>
+	<true/>
+	<key>UISupportedInterfaceOrientations</key>
+	<array>
+		<string>UIInterfaceOrientationPortrait</string>
+	</array>
+	<key>UISupportedInterfaceOrientations~ipad</key>
+	<array>
+		<string>UIInterfaceOrientationLandscapeLeft</string>
+		<string>UIInterfaceOrientationLandscapeRight</string>
+		<string>UIInterfaceOrientationPortrait</string>
+		<string>UIInterfaceOrientationPortraitUpsideDown</string>
+	</array>
+	<key>UIViewControllerBasedStatusBarAppearance</key>
+	<false/>
+</dict>
+</plist>

options-dev.plist

@@ -10,17 +10,17 @@
 	<string>development</string>
 	<key>provisioningProfiles</key>
 	<dict>
-		<key>ca.bc.gov.BCWallet</key>
-		<string>BC Wallet - Development Jason</string>
+		<key>ca.qc.gouv.portefeuillemobileqc</key>
+		<string>Portefeuille Qc</string>
 	</dict>
 	<key>signingCertificate</key>
-	<string>67D6BA0FEC3E43792AABC24ED686303A9E3BB23F</string>
+	<string>Signing certificate</string>
 	<key>signingStyle</key>
 	<string>manual</string>
 	<key>stripSwiftSymbols</key>
 	<true/>
 	<key>teamID</key>
-	<string>L796QSLV3E</string>
+	<string>2RST8749NS</string>
 	<key>thinning</key>
 	<string>&lt;none&gt;</string>
 </dict>

options.plist

@@ -17,7 +17,7 @@
 	<key>provisioningProfiles</key>
 	<dict>
 		<key>ca.qc.gouv.portefeuillemobileqc</key>
-		<string>06adc3cb-97cd-4161-a070-af422c16a441</string>
+		<string>d17832aa-855e-476a-8741-4cf396a65204</string>
 	</dict>
 </dict>
 </plist>

patch/Qc/00-setup.patch

@@ -18,7 +18,7 @@ index 4cfa156..30dc17d 100644
 -				DEVELOPMENT_TEAM = "";
 +				DEVELOPMENT_TEAM = "2RST8749NS";
  				INFOPLIST_FILE = AriesBifoldTests/Info.plist;
- 				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
+ 				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
  				LD_RUNPATH_SEARCH_PATHS = (
 @@ -537,9 +537,10 @@
  			buildSettings = {

release.xcconfig

@@ -1,5 +1,5 @@
 CODE_SIGN_STYLE=Manual
 DEVELOPMENT_TEAM=2RST8749NS
 PRODUCT_BUNDLE_IDENTIFIER=ca.qc.gouv.portefeuillemobileqc
-PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]=Portefeuille Numerique Qc (Ne pas supprimer)
-CODE_SIGN_IDENTITY=iPhone Distribution: Ministere de la Cybersecurite et du Numerique (2RST8749NS)
+PROVISIONING_PROFILE_SPECIFIER=d17832aa-855e-476a-8741-4cf396a65204
+CODE_SIGN_IDENTITY=Apple Distribution: Ministere de la Cybersecurite et du Numerique (2RST8749NS)