Hopeful or Partial fix For Custom Graphs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes an NPE when the plugin name fails to parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add a missing URL format that (I think?) is used in custom metrics. It also fixes an NPE when the plugin name fails to parse.
I couldn't fully test this, but would be willing to dig further- is the mysql schema available anywhere? I couldn't find it in the repo.
This did cause data processing to get farther in local testing, it was throwing an NPE on my plugin's data submission prior to this fix. It dies later on trying to lookup the Plugin now, but I think that's due to my empty metrics schema.
If you could take a look at all this, I'd hugely appreciate it- I would really love to see my custom metrics showing up. There may be a client-side fix or work-around for this as well, which I will be looking into :)