Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #57

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Update dependencies #57

merged 5 commits into from
Nov 20, 2023

Conversation

ianmkenney
Copy link
Member

Fixes #56

Changes made in this Pull Request:

  • Updated the dependencies in pyproject.toml
  • Updated the dependencies in test_env.yaml

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

I've confirmed that tests pass locally both using the test_env.yaml for conda as well as a purely pip installed environment from the pyproject.toml.

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Merging #57 (7ac9dec) into main (8df686c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

orbeckst
orbeckst requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update https://github.com/MDAnalysis/mdaencore/blob/main/docs/requirements.yaml

@ianmkenney
Copy link
Member Author

We also need to update setup.py (RTD installs from here)

@orbeckst
Copy link
Member

@ianmkenney please merge if all is good.

@ianmkenney ianmkenney merged commit 8be0f92 into main Nov 20, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees

@ianmkenney ianmkenney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dependencies in pyproject.toml
2 participants
@ianmkenney @orbeckst