Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build wheels with numpy 1.25+ #4198

Merged
merged 17 commits into from
Aug 15, 2023
Merged

Build wheels with numpy 1.25+ #4198

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d54db2f
build with numpy 1.25+
IAlibay Jul 14, 2023
21cecd1
switch to pip install -e
IAlibay Aug 14, 2023
ebc8b95
some changes, some debugging
IAlibay Aug 14, 2023
0926a7c
Merge branch 'develop' into numpy-1.25
IAlibay Aug 14, 2023
6f93755
fix typo in azp
IAlibay Aug 14, 2023
e5aa75c
micromamba list
IAlibay Aug 14, 2023
d4abcb3
add verbosity
IAlibay Aug 14, 2023
2c48989
disable build isolation
IAlibay Aug 14, 2023
e00333a
add isolation flag
IAlibay Aug 14, 2023
520da67
be explicit about isolation (even though the default is ok)
IAlibay Aug 14, 2023
717a6ce
actually pass the build isolation flag
IAlibay Aug 14, 2023
edf9cb8
inputs not input
IAlibay Aug 14, 2023
2ebccb5
try to fix typo
IAlibay Aug 15, 2023
bb4b019
fix flag assignment
IAlibay Aug 15, 2023
2d04c4c
remove cron shim
IAlibay Aug 15, 2023
2bd32ca
update changelog
IAlibay Aug 15, 2023
a33cbd9
Add comments on build isolation use
IAlibay Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions package/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,11 @@
requires = [
"Cython>=0.28",
"packaging",
# lowest NumPy we can use for a given Python,
# In part adapted from: https://github.com/scipy/oldest-supported-numpy/blob/main/setup.cfg
# except for more exotic platform (Mac Arm flavors)
# aarch64, AIX, s390x, and arm64 all support 1.21 so we can safely pin to this
# Note: MDA does not build with PyPy so we do not support it in the build system
# Scipy: On windows avoid 1.21.6, 1.22.0, and 1.22.1 because they were built on vc142
# Let's set everything to this version to make things clean, also avoids other issues
# on other archs
"numpy==1.22.3; python_version=='3.9' and platform_python_implementation != 'PyPy'",
"numpy==1.22.3; python_version=='3.10' and platform_python_implementation != 'PyPy'",
"numpy==1.23.2; python_version=='3.11' and platform_python_implementation != 'PyPy'",
# For unreleased versions of Python there is currently no known supported
# NumPy version. In that case we just let it be a bare NumPy install
"numpy<2.0; python_version>='3.12'",
# NumPy 1.25+ offers backwards compatibility that tracks with greater
# than NEP29 (see: https://numpy.org/doc/stable/dev/depending_on_numpy.html#adding-a-dependency-on-numpy)
# We pin our wheel installation to that and a maximum of numpy 2.0 since
# this will likely involve several breaking changes
"numpy>=1.25,<2.0; python_version>='3.9'",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumPy 1.25+ is backwards compatible with its C/C++ API, so (as shown in the CI tests) we can build with it and then use an older version of NumPy at runtime and things just work.

"setuptools",
"wheel",
]
Expand Down