-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre release 2.6.0 #4241
Pre release 2.6.0 #4241
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4241 +/- ##
==========================================
Coverage 93.62% 93.62%
==========================================
Files 179 193 +14
Lines 24199 25304 +1105
Branches 4064 4064
==========================================
+ Hits 22657 23692 +1035
- Misses 1026 1096 +70
Partials 516 516
☔ View full report in Codecov by Sentry. |
@MDAnalysis/coredevs can I have a quick thumbs up here? see here for tthe relevant step in the release process: https://userguide.mdanalysis.org/dev/preparing_releases_and_hotfixes.html#getting-the-develop-branch-ready-for-a-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I guess the list of relevant files to be changed in the User Guide needs to be updated?
Ah thanks for pointing it out, looks like I deleted the |
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4241.org.readthedocs.build/en/4241/