-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try 3.12.0-rc1 #4265
Try 3.12.0-rc1 #4265
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4265 +/- ##
==========================================
Coverage 93.40% 93.40%
==========================================
Files 170 184 +14
Lines 22257 23365 +1108
Branches 4071 4071
==========================================
+ Hits 20790 21825 +1035
- Misses 951 1024 +73
Partials 516 516 ☔ View full report in Codecov by Sentry. |
Ok we're blocked by NumPy funnily enough, they have a pin on a too old version of setuptools for 1.25.2 (it's a weird world). |
@@ -17,7 +17,7 @@ requires = [ | |||
# For unreleased versions of Python there is currently no known supported | |||
# NumPy version. In that case we just let it be a bare NumPy install | |||
"numpy<2.0; python_version>='3.12'", | |||
"setuptools", | |||
"setuptools>=68.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok we're blocked by NumPy funnily enough, they have a pin on a too old version of setuptools for 1.25.2 (it's a weird world).
That doesn't sound right, the first NumPy version to support Python 3.12.0rc1
is the beta release 1.26.0b1
I used to build SciPy wheels, which should drop setuptools
for meson
.
Two tricky things to consider that should help out:
3.12
won't pickup the release candidate inpyproject.toml
logic so you'll need: NumPy does not install on Python 3.12.0b1 numpy/numpy#23808 (comment)- You may also need
PIP_PRE
per: NumPy does not install on Python 3.12.0b1 numpy/numpy#23808 (comment)
Anyway, hope that helps, but NumPy shouldn't be holding you back, should just be a matter of the tweaks mentioned there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I did for example: https://github.com/scipy/scipy/blob/maintenance/1.11.x/pyproject.toml#L50
(actually I'm not sure I should have hard pinned like that, but anyway it worked)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And PIP_PRE
is set here: https://github.com/scipy/scipy/blob/maintenance/1.11.x/.github/workflows/wheels.yml#L136
(using that extra index shouldn't be needed anymore though I don't think since the NumPy beta is on PyPI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tylerjereddy that's super useful info!
I think here I was mostly looking to see "what bits of upstream are we waiting on for py3.12", rather than adding actual shims to get py3.12 to work.
What I might do is stick the py3.12rc under the nightly wheels cron checks (which turns off build isolation) and see if it works there. If so, we can revisit adding it to normal CI checks when numpy 1.26 comes out.
Edit: nevermind, the nightly wheels cron checks are a full dependency check, there's no way that would work, not with rdkit and openmm in that list.
Cycling for CI now that 1.26 is out. |
Ok there's a lot of issues to digest and deal with, Py312 is going to be interesting... |
If there is anything upstream that causes friction feel free to ping me to look at it. |
Thanks @tylerjereddy - I think for the most part we're only just struggling with some cpython changes that are catching out a few things, primarily |
Fixes #
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4265.org.readthedocs.build/en/4265/