Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors due to make html #4365

Merged

Conversation

HeetVekariya
Copy link
Contributor

@HeetVekariya HeetVekariya commented Dec 14, 2023

Fixes #4362

Changes made in this Pull Request:

  1. To solve html_static_path error, made the html_static_path list an empty list
  2. To solve Indentation error, added an indent of 4 spaces

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4365.org.readthedocs.build/en/4365/

Copy link

github-actions bot commented Dec 14, 2023

Linter Bot Results:

Hi @HeetVekariya! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad40922) 93.37% compared to head (bd1aad9) 93.37%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4365     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22340    23453   +1113     
  Branches      4085     4085             
==========================================
+ Hits         20859    21899   +1040     
- Misses         963     1036     +73     
  Partials       518      518             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work tracking down the issues and figuring out the solution, @HeetVekariya -- looks great! Can I just ask that you make the CHANGELOG message a it more specific? These errors were part of generally building documentation, not just running make html, so something more along the lines of fixing building documentation is more informative here.

@orbeckst
Copy link
Member

@lilyminium can I please assign you as the PR shepherd as you've already done the work of reviewing it? If you don't have time please unassign yourself and ping me. Thanks!

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @HeetVekariya for these fixes!

@lilyminium lilyminium merged commit 2d6a8ce into MDAnalysis:develop Dec 15, 2023
23 checks passed
@HeetVekariya HeetVekariya deleted the fix/static-directory-issue branch December 16, 2023 12:25
ljwoods2 pushed a commit to ljwoods2/mdanalysis that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors due to make html
3 participants