-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: errors due to make html
#4365
fix: errors due to make html
#4365
Conversation
Linter Bot Results:Hi @HeetVekariya! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4365 +/- ##
==========================================
Coverage 93.37% 93.37%
==========================================
Files 170 184 +14
Lines 22340 23453 +1113
Branches 4085 4085
==========================================
+ Hits 20859 21899 +1040
- Misses 963 1036 +73
Partials 518 518 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work tracking down the issues and figuring out the solution, @HeetVekariya -- looks great! Can I just ask that you make the CHANGELOG message a it more specific? These errors were part of generally building documentation, not just running make html
, so something more along the lines of fixing building documentation is more informative here.
@lilyminium can I please assign you as the PR shepherd as you've already done the work of reviewing it? If you don't have time please unassign yourself and ping me. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thank you @HeetVekariya for these fixes!
Fixes #4362
Changes made in this Pull Request:
html_static_path
error, made thehtml_static_path
list an empty listIndentation
error, added an indent of 4 spacesPR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4365.org.readthedocs.build/en/4365/