Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Transformations.py doctest errors #4370

Merged

Conversation

HeetVekariya
Copy link
Contributor

@HeetVekariya HeetVekariya commented Dec 16, 2023

Fixes #3925

Changes made in this Pull Request:

  • Doctest for Transformations.py (package/MDAnalysis/lib/transformations.py) file contains errors for this three functions:
  1. clip_matrix (Indentation error): Correction in indentation
  2. uler_matrix (Comma error): Added comma
  3. quaternion_slerp (EOF error): Added ... before starting of new line

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4370.org.readthedocs.build/en/4370/

Copy link

github-actions bot commented Dec 16, 2023

Linter Bot Results:

Hi @HeetVekariya! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d6a8ce) 93.37% compared to head (6a597e1) 93.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4370     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22340    23453   +1113     
  Branches      4085     4085             
==========================================
+ Hits         20859    21899   +1040     
- Misses         963     1036     +73     
  Partials       518      518             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoStoe JoStoe mentioned this pull request Dec 16, 2023
5 tasks
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HeetVekariya, LGTM.

@RMeli RMeli merged commit 5eca713 into MDAnalysis:develop Dec 16, 2023
23 checks passed
@HeetVekariya HeetVekariya deleted the fix/transformation-doctest-errors branch December 17, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] doctest MEGA-issue
2 participants