Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upper python+numpy pin for build system #4385

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Fix upper python+numpy pin for build system #4385

merged 1 commit into from
Dec 24, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Dec 24, 2023

Should be 3.13 not 3.12

Changes made in this Pull Request:

  • Updates upper build to be >=3.13 instead of >=3.12

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4385.org.readthedocs.build/en/4385/

Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edda942) 93.41% compared to head (47fa835) 93.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4385     +/-   ##
==========================================
  Coverage    93.41%   93.41%             
==========================================
  Files          171      185     +14     
  Lines        22511    23624   +1113     
  Branches      4129     4129             
==========================================
+ Hits         21028    22068   +1040     
- Misses         963     1036     +73     
  Partials       520      520             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Dec 24, 2023

Failure is expected, merging.

@IAlibay IAlibay merged commit 770a577 into develop Dec 24, 2023
24 of 26 checks passed
@IAlibay IAlibay deleted the fix-build branch December 24, 2023 13:27
ljwoods2 pushed a commit to ljwoods2/mdanalysis that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants