Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy action #4396

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Fix deploy action #4396

merged 3 commits into from
Dec 27, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Dec 27, 2023

Changes made in this Pull Request:

  • Updated the deploy action to use the right upload to pypi version for full pypi uploads

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4396.org.readthedocs.build/en/4396/

Copy link
Contributor

@fiona-naughton fiona-naughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😊

Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@IAlibay
Copy link
Member Author

IAlibay commented Dec 27, 2023

Merging without CI here - it's not touching anything that is covered by CI.

@IAlibay IAlibay merged commit 97b5a61 into develop Dec 27, 2023
16 of 24 checks passed
@IAlibay IAlibay deleted the fix-deploy branch December 27, 2023 00:09
ljwoods2 pushed a commit to ljwoods2/mdanalysis that referenced this pull request Dec 29, 2023
* Fix deploy action, using the correct version number for the pypi upload method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants