-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new M1 macOS GitHub runner to CI #4442
Changes from 37 commits
d6b164f
3fc3759
691e6a9
20b927e
907fedd
4aa042c
d66e3fe
c90db41
70243fc
8a2e0cd
3c93757
68fb913
742c0d1
dec35f9
8f1c54f
e5a31f7
a11dbc2
e2af3c5
954fef0
e9f87ed
6af293a
9388477
a17d6b9
3af6982
a87e9e3
ad2b7b0
bfab56d
be209d6
154ded7
4ae688e
149af50
82359f0
6111a19
91605f6
d109e59
fa76401
4cb63d4
c6ceee9
ce9d434
9c23ba0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -264,14 +264,16 @@ jobs: | |
pypi-latest-release: | ||
# A set of runner to check that the latest conda release works as expected | ||
if: "github.repository == 'MDAnalysis/mdanalysis'" | ||
runs-on: ${{ matrix.os }}-latest | ||
runs-on: ${{ matrix.os }} | ||
timeout-minutes: 60 | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu, macos, windows] | ||
os: [ubuntu-latest, macos-latest, macos-14, windows-latest] | ||
python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
wheels: ['true', 'false'] | ||
exclude: | ||
- {os: "macos-14", python-version: "3.9"} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this being disabled? as show in #4445 we should be able to build on 3.9 with macos-14 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I got this failure. Looking at the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's.. odd. I've not glanced upstream, but we should probably keep an eye on updates - it's very possible they couldn't backport stuff properly until they had their own CI runners for this.
RMeli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
steps: | ||
# Checkout to have access to local actions (i.e. setup-os) | ||
- uses: actions/checkout@v4 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be worth enabling cron CI - I can't remember if non-wheel build will work here, you might need to exclude macos-14 & wheels=false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4442