Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new M1 macOS GitHub runner to CI #4442
Add new M1 macOS GitHub runner to CI #4442
Changes from 36 commits
d6b164f
3fc3759
691e6a9
20b927e
907fedd
4aa042c
d66e3fe
c90db41
70243fc
8a2e0cd
3c93757
68fb913
742c0d1
dec35f9
8f1c54f
e5a31f7
a11dbc2
e2af3c5
954fef0
e9f87ed
6af293a
9388477
a17d6b9
3af6982
a87e9e3
ad2b7b0
bfab56d
be209d6
154ded7
4ae688e
149af50
82359f0
6111a19
91605f6
d109e59
fa76401
4cb63d4
c6ceee9
ce9d434
9c23ba0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be worth enabling cron CI - I can't remember if non-wheel build will work here, you might need to exclude macos-14 & wheels=false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4442
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this being disabled? as show in #4445 we should be able to build on 3.9 with macos-14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this failure. Looking at the
versions-manifest.json
as suggested, it looks like all3.9
is not provided witharch: arm64
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's.. odd. I've not glanced upstream, but we should probably keep an eye on updates - it's very possible they couldn't backport stuff properly until they had their own CI runners for this.