-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed pca.py errors #4457
fixed pca.py errors #4457
Conversation
Hello @nataliyah123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-02-14 06:32:10 UTC |
Linter Bot Results:Hi @nataliyah123! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4457 +/- ##
==========================================
Coverage 93.37% 93.38%
==========================================
Files 171 185 +14
Lines 21736 22858 +1122
Branches 4012 4014 +2
==========================================
+ Hits 20297 21346 +1049
- Misses 952 1025 +73
Partials 487 487 ☔ View full report in Codecov by Sentry. |
I have made some changes, but there are some tests that are failing, I think they are not related to the changes I made, and this is a known issue to the team (IDK). there are some changes that 'hmacdope' has suggested in another PR like |
@orbeckst. I think some other candidate has already made a PR for the same issue long before I did. some how I missed it so I am closing this PR. |
Partially fixes #3925
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin