Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed pca.py errors #4457

Closed
wants to merge 4 commits into from
Closed

Conversation

nataliyah123
Copy link
Contributor

@nataliyah123 nataliyah123 commented Feb 14, 2024

Partially fixes #3925

Changes made in this Pull Request:

  • Fixed setup errors (pca.py)
  • Fixed unmatched outputs (pca.py)

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin

@pep8speaks
Copy link

pep8speaks commented Feb 14, 2024

Hello @nataliyah123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-02-14 06:32:10 UTC

Copy link

github-actions bot commented Feb 14, 2024

Linter Bot Results:

Hi @nataliyah123! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e189a90) 93.37% compared to head (e924efe) 93.38%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4457     +/-   ##
==========================================
  Coverage    93.37%   93.38%             
==========================================
  Files          171      185     +14     
  Lines        21736    22858   +1122     
  Branches      4012     4014      +2     
==========================================
+ Hits         20297    21346   +1049     
- Misses         952     1025     +73     
  Partials       487      487             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nataliyah123
Copy link
Contributor Author

I have made some changes, but there are some tests that are failing, I think they are not related to the changes I made, and this is a known issue to the team (IDK). there are some changes that 'hmacdope' has suggested in another PR like ..code-block:: python instead of..testsetup::, I will make the changes according to his suggestion, if you want me to.

@nataliyah123
Copy link
Contributor Author

@orbeckst. I think some other candidate has already made a PR for the same issue long before I did. some how I missed it so I am closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] doctest MEGA-issue
2 participants