-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlignTraj Writer kwargs fix #4565
Conversation
Hello @ljwoods2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-05-26 22:47:41 UTC |
Linter Bot Results:Hi @ljwoods2! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4565 +/- ##
===========================================
- Coverage 93.64% 93.41% -0.24%
===========================================
Files 168 180 +12
Lines 21254 22167 +913
Branches 3918 3919 +1
===========================================
+ Hits 19904 20707 +803
- Misses 892 1000 +108
- Partials 458 460 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! The functional parts all look good to me!
Regarding your final black modification, please see #2450 for details but you should only format the lines you change to avoid complaints from #4565 (comment).
My apologies, I forgot to turn off my autoformatter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @ljwoods2
Fixes #4564
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4565.org.readthedocs.build/en/4565/