Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdist CI tests for package name normalization #4572

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Apr 21, 2024

Fixes #

Changes made in this Pull Request:

  • Package names now normalize to lower case, match that in CI testss

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4572.org.readthedocs.build/en/4572/

Copy link

github-actions bot commented Apr 21, 2024

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (73acc9b) to head (6864b32).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4572      +/-   ##
===========================================
- Coverage    93.66%   93.64%   -0.03%     
===========================================
  Files          168      180      +12     
  Lines        21248    22327    +1079     
  Branches      3917     3917              
===========================================
+ Hits         19902    20908    +1006     
- Misses         888      961      +73     
  Partials       458      458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay requested a review from RMeli April 21, 2024 14:18
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. CI failures are spurious.

@RMeli RMeli merged commit 804b607 into develop Apr 22, 2024
21 of 23 checks passed
@IAlibay IAlibay deleted the fix-sdist-tests branch July 22, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants