Remove default parallelizable parameter in NoJump transformation #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter Bot Results:Hi @marinegor! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4604 +/- ##
===========================================
- Coverage 93.64% 93.45% -0.20%
===========================================
Files 168 180 +12
Lines 21254 22333 +1079
Branches 3918 3619 -299
===========================================
+ Hits 19904 20871 +967
- Misses 892 1000 +108
- Partials 458 462 +4 ☔ View full report in Codecov by Sentry. |
orbeckst
approved these changes
May 22, 2024
|
Hello @marinegor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-05-23 23:23:42 UTC |
|
oops... Will merge when tests are ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4259
Changes made in this Pull Request:
parallelizableargument ofNoJumptransformation to avoid accidentally passingparallelizable=TruePR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4604.org.readthedocs.build/en/4604/