-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: array to scalar deprecation warning #4608
fix: array to scalar deprecation warning #4608
Conversation
Hello @Rohitthakan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS
as part of this PR.
Linter Bot Results:Hi @Rohitthakan! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rohitthakan, thank you for contributing to MDAnalysis. What is the reason for replacing the docstrings with a comment? Please revert these changes.
@RMeli could you please take on the role of PR shepherd? If it becomes to much, please say something and unassign yourself. Thanks! |
@Rohitthakan please also have a look at the tests, they are all failing. |
Hi @Rohitthakan, are you still working/interested in working on this? |
Closing for lack of replies. Please feel free to re-open if you are still working on it and want to move forward. |
Fixes #4339
Changes made in this Pull Request:
This PR fixes the array to scalar deprecation warning
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4608.org.readthedocs.build/en/4608/