Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: array to scalar deprecation warning #4608

Closed
wants to merge 2 commits into from
Closed

fix: array to scalar deprecation warning #4608

wants to merge 2 commits into from

Conversation

Rohitthakan
Copy link

@Rohitthakan Rohitthakan commented May 29, 2024

Fixes #4339

Changes made in this Pull Request:
This PR fixes the array to scalar deprecation warning

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4608.org.readthedocs.build/en/4608/

@pep8speaks
Copy link

Hello @Rohitthakan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 217:80: E501 line too long (123 > 79 characters)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

Copy link

Linter Bot Results:

Hi @Rohitthakan! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ✅ Passed

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/9281691657/job/25538172389


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rohitthakan, thank you for contributing to MDAnalysis. What is the reason for replacing the docstrings with a comment? Please revert these changes.

@orbeckst
Copy link
Member

@RMeli could you please take on the role of PR shepherd? If it becomes to much, please say something and unassign yourself. Thanks!

@RMeli
Copy link
Member

RMeli commented May 31, 2024

@Rohitthakan please also have a look at the tests, they are all failing.

@RMeli
Copy link
Member

RMeli commented Jun 17, 2024

Hi @Rohitthakan, are you still working/interested in working on this?

@RMeli RMeli added close? Evaluate if issue/PR is stale and can be closed. labels Jun 17, 2024
@RMeli
Copy link
Member

RMeli commented Jun 29, 2024

Closing for lack of replies. Please feel free to re-open if you are still working on it and want to move forward.

@RMeli RMeli closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
close? Evaluate if issue/PR is stale and can be closed. Component-Analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array to scalar deprecation warning
4 participants