Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding robustica option to ICA decomposition to achieve consistent results #1013
Adding robustica option to ICA decomposition to achieve consistent results #1013
Changes from 14 commits
f4eaa3e
b0cac3a
55c2ae4
cd55a3f
2d9b007
09e565e
fc5f9ea
4fc3043
a20ff57
cc5e05d
a449fec
78c8140
ac85e6a
979d026
71d8d4a
cac38cd
5fcf148
b7d08e9
a113423
b60e9a6
45c95ce
8e6878f
88fd148
a221e72
8622a9b
419e9d4
d29a91b
efb712e
dee68ec
171a835
4b86fe2
c01ec51
cd50037
54a4ac3
9bb021a
cd29060
2a868e3
ed10ade
8a14277
b793d83
1b1eb38
87965f4
8743aca
42372e3
3d88eb4
1aac94a
2b0ef67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to open an issue so we can discuss where we move these defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #1132.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
anglada2022
?Got the following near the end of a run
And I notice that all other files in the
references.bib
are in that lower format + no ':'. Maybe the case is handled, but seems like the colon not?Or line 122 in ica.py should have the colon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dowdlelt. Yes, that is anglada2022. I am currently working on finalising this PR and all these issues will be resolved soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome news, looking forward to it!